fix: vercel og patch not moving to right node_modules directory #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 26b47bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
vicb
reviewed
Feb 13, 2025
packages/cloudflare/src/cli/build/patches/ast/patch-vercel-og-library.ts
Show resolved
Hide resolved
vicb
reviewed
Feb 13, 2025
packages/cloudflare/src/cli/build/patches/ast/patch-vercel-og-library.ts
Outdated
Show resolved
Hide resolved
vicb
reviewed
Feb 13, 2025
packages/cloudflare/src/cli/build/patches/ast/patch-vercel-og-library.ts
Show resolved
Hide resolved
vicb
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #376
In some monorepo projects when running build there is a node_modules inside
server-functionsbut not insideserver-functions/{projectPath}.This change to check for the existence of the package-scoped node_modules before choosing it over the non-package-scoped one.
Not quite sure how simple it would be to add an e2e for this because it's dependent on the monorepo structure and I believe it would be hit for us due to having multiple apps