Skip to content

Conversation

@conico974
Copy link
Collaborator

@conico974 conico974 commented Feb 21, 2025

There has been a few changes in opennextjs/opennextjs-aws#725 to handle the node middleware.
It also includes changes for next 15.2 and page router data json not working opennextjs/opennextjs-aws#756
It changes the dependency on aws to "@opennextjs/aws": "https://pkg.pr.new/@opennextjs/aws@756"
This PR just add the necessary changes in cloudflare so that we could merge it in aws.

Technically the node middleware should just work in cloudflare but i haven't tested it (and i'm not sure if it even make sense)

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: bfc26de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 21, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@403

commit: bfc26de

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conico974
Copy link
Collaborator Author

I've put this as a draft for now. No need to merge this one until opennextjs/opennextjs-aws#725 is reviewed and merged.
And there is no rush since node middleware will likely stay in canary for now

@conico974 conico974 force-pushed the chore/node-middleware branch from 0756314 to bbd41e6 Compare February 27, 2025 16:02
@conico974 conico974 marked this pull request as ready for review February 27, 2025 16:24
@vicb vicb changed the title fix: update @opennextjs/aws dependency version to 725 fix: update @opennextjs/aws dependency version to 756 Feb 27, 2025
@conico974 conico974 merged commit 47b673a into opennextjs:main Feb 27, 2025
7 checks passed
@conico974
Copy link
Collaborator Author

Thanks for the review @vicb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants