Skip to content

un-skip the ssr loading e2e test in the app-router app #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025
Merged

un-skip the ssr loading e2e test in the app-router app #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7be2a3
un-skip the ssr loading e2e test in the `app-router` app
dario-piotrowicz Feb 24, 2025
01c1e6b
remove outdated comments
dario-piotrowicz Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions examples/e2e/app-router/e2e/sse.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
// NOTE: loading.tsx is currently broken on open - next
// This works locally but not on deployed apps

import { expect, test } from "@playwright/test";

// NOTE: We don't await page load b/c we want to see the Loading page
Expand Down
6 changes: 1 addition & 5 deletions examples/e2e/app-router/e2e/ssr.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
// NOTE: loading.tsx is currently broken on open - next
// This works locally but not on deployed apps

import { expect, test } from "@playwright/test";

// NOTE: We don't await page load b/c we want to see the Loading page
// loading.tsx doesn't currently work: https://github.com/opennextjs/opennextjs-cloudflare/issues/313
test.skip("Server Side Render and loading.tsx", async ({ page }) => {
test("Server Side Render and loading.tsx", async ({ page }) => {
test.setTimeout(600000);
await page.goto("/");
await page.getByRole("link", { name: "SSR" }).click();
Expand Down