Skip to content

Conversation

james-elicx
Copy link
Collaborator

@james-elicx james-elicx commented Mar 10, 2025

Service bindings are required for fetching the same worker in production.

A bit of a shame that our local e2es were unable to catch this as wrangler doesn't fail when doing fetches in local mode.

Docs PR - opennextjs/docs#89

Copy link

changeset-bot bot commented Mar 10, 2025

🦋 Changeset detected

Latest commit: b7f7b12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Mar 10, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@445

commit: b7f7b12

@james-elicx james-elicx linked an issue Mar 10, 2025 that may be closed by this pull request
@james-elicx james-elicx marked this pull request as ready for review March 10, 2025 08:29
@james-elicx james-elicx requested a review from vicb March 10, 2025 08:29
@conico974
Copy link
Collaborator

That's really weird, in the issue they say that it works fine with direct in production, which should do the exact same thing

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @james-elicx, LGTM.

Maybe add a little more details to the changeset for the changelog

@james-elicx james-elicx force-pushed the james/fix-memory-queue branch from 34034e5 to b7f7b12 Compare March 10, 2025 09:05
@vicb
Copy link
Contributor

vicb commented Mar 10, 2025

That's really weird, in the issue they say that it works fine with direct in production, which should do the exact same thing

Any chance that direct goes through the path @dario-piotrowicz modified (removing an internal header).
I might be off, still trying to catch up with everything...

@james-elicx
Copy link
Collaborator Author

That's really weird, in the issue they say that it works fine with direct in production, which should do the exact same thing

Just tried the direct queue and that doesn't work with their repro when deployed either for me.

@james-elicx james-elicx merged commit 6a389fe into main Mar 10, 2025
7 checks passed
@james-elicx james-elicx deleted the james/fix-memory-queue branch March 10, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] memory-queue response always STALE

3 participants