Skip to content

refactor: switch to bundled middleware #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2025
Merged

refactor: switch to bundled middleware #497

merged 3 commits into from
Mar 25, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Mar 25, 2025 •
edited
Loading

This PR:

  • Switch to using a bundled middleware - we were previsouly generating an external middleware but wrangler was bundling it together with the server bundle. We will revisit once we can deploy the middleware to a different worker.
  • The server handler is now imported right before being used so that the env vars are guaranteed to be populated and the ALS initializzed.

Depends on opennextjs/opennextjs-aws#798

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 7dbc8fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 25, 2025 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@497

commit: 7dbc8fe

@vicb vicb requested review from conico974 and james-elicx March 25, 2025 12:24
conico974
conico974 approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor nits

@vicb vicb merged commit 958f322 into main Mar 25, 2025
7 checks passed
@vicb vicb deleted the vb-branch-2 branch March 25, 2025 13:58
@workers-frameworks workers-frameworks mentioned this pull request Mar 25, 2025
Merged
@blitss blitss mentioned this pull request Mar 25, 2025
Closed
@raffpaquin raffpaquin mentioned this pull request Mar 25, 2025
Closed
@vicb vicb mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@conico974 conico974 conico974 approved these changes

@james-elicx james-elicx Awaiting requested review from james-elicx

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vicb @conico974