refactor: update naming and layout #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 85c308b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
reviewed
Mar 25, 2025
james-elicx
previously approved these changes
Mar 25, 2025
packages/cloudflare/src/api/overrides/tag-cache/d1-tag-cache.ts
Outdated
Show resolved
Hide resolved
james-elicx
reviewed
Mar 25, 2025
james-elicx
reviewed
Mar 25, 2025
packages/cloudflare/src/api/overrides/incremental-cache/r2-incremental-cache.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: James Anderson <[email protected]>
Co-authored-by: James Anderson <[email protected]>
|
I think I have addressed the feedback, I'm going to add a changeset |
james-elicx
approved these changes
Mar 26, 2025
conico974
approved these changes
Mar 26, 2025
Co-authored-by: conico974 <[email protected]>
vicb
commented
Mar 26, 2025
vicb
commented
Mar 26, 2025
|
Thanks for the review 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
NEXT_CACHE_WORKERS_KV->NEXT_CACHE_KVdurable-queue->do-queueNEXT_CACHE_REVALIDATION_DURABLE_OBJECT->NEXT_CACHE_DO_REVALIDATIONoverridesNEXT_CACHE_D1_TAGS_TABLE, NEXT_CACHE_D1_REVALIDATIONS_TABLENEXT_CACHE_REVALIDATION_WORKER->WORKER_SELF_REFERENCE(I wish we can drop that ASAP)NEXT_CACHE_KV->NEXT_INC_CACHE_KVNEXT_CACHE_R2_...->NEXT_INC_CACHE_R2_...NEXT_CACHE_D1->NEXT_TAG_CACHE_D1NEXT_CACHE_DO_REVALIDATION->NEXT_CACHE_DO_QUEUENEXT_CACHE_DO_...->NEXT_TAG_CACHE_DO_......->NEXT_CACHE_DO_QUEUE_...TODO: changeset
What about renaming
NEXT_CACHE_REVALIDATION_WORKERtoNEXT_CACHE_SERVICE_SELFor any better idea?/cc @conico974 @james-elicx @dario-piotrowicz