Skip to content

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Apr 7, 2025

  • The app does not build because of it uses the edge runtime (this could be fix by changing the way font is retrieved)
  • It had no e2e
  • It requires setting SHOPIFY_REVALIDATION_SECRET and SHOPIFY_STOREFRONT_ACCESS_TOKEN so it errors out of the box

Copy link

changeset-bot bot commented Apr 7, 2025

⚠️ No Changeset found

Latest commit: 7556f2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Apr 7, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@542

commit: 7556f2b

@vicb vicb requested review from conico974 and james-elicx April 7, 2025 14:19
@vicb
Copy link
Contributor Author

vicb commented Apr 7, 2025

Thanks Nico!

@vicb vicb merged commit c2fc0e4 into main Apr 7, 2025
7 checks passed
@vicb vicb deleted the vb-branch-4 branch April 7, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants