Extract the worker init code to a separate file #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9fff83d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
approved these changes
Apr 10, 2025
conico974
reviewed
Apr 10, 2025
| Object.assign(globalThis, { | ||
| Request: CustomRequest, | ||
| // This is only needed for an external middleware bundle | ||
| __dangerous_ON_edge_converter_returns_request: true, |
There was a problem hiding this comment.
Do we want to add that actually for an external middleware ? This means that the output of the middleware will be a Request.
It's fine when everything was in 1 worker, but if we have multiple worker it won't work as expected (or it will require a custom converter/wrapper to forward the request)
There was a problem hiding this comment.
That's right, I'll remove this.
Thanks for catching that.
vicb
commented
Apr 10, 2025
vicb
commented
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been willing to do this for a long time...
The init code does not belong to the server bundle, it can be used for i.e. an external middleware.
Further benefits: