Skip to content

Conversation

conico974
Copy link
Collaborator

In some cases it's interesting to override some of the default provided by cloudflare.
This add an option in open-next.config.ts to only add a warning in case of incorrect validation instead of throwing an error

Copy link

changeset-bot bot commented May 20, 2025

🦋 Changeset detected

Latest commit: d980d40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented May 20, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@675

commit: d980d40

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove this file from the PR?

"@opennextjs/cloudflare": patch
---

add an option to not throw on validation of the config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
add an option to not throw on validation of the config
add a `cloudflare.dangerousDisableConfigValidation` config option to not throw on validation of the config

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It looks like the PR has also changes from #674, could you please remove them.

Thanks!

@conico974 conico974 force-pushed the feat/dangerous-disable-validation branch from a342c2f to d980d40 Compare May 20, 2025 09:01
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conico974 conico974 merged commit e6040bc into opennextjs:main May 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants