Add the routePreloadingBehavior to the options of defineCloudflareConfig
#696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 16417c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
Yeah i think it's a quick fix, but ideally, we should move the preload in the waitUntil after the request is done. This way we'll barely consume any cpu cycle from the current request and really execute everything in the background.
It should be done in AWS though
james-elicx
approved these changes
Jun 4, 2025
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@conico974 what do you think about this PR?
When investigating perf issue with https://github.com/LubomirGeorgiev/cloudflare-workers-nextjs-saas-template, I measure the preload to be 200-300ms.
This change could save some CPU cycles.