Skip to content

fix deploying Cloudflare:sockets and cloudflare email workers #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix deploying Cloudflare:sockets and cloudflare email workers #723

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8172457
fix deploy
franz101 Jun 10, 2025
a9d7ea8
Update bundle-server.ts
franz101 Jun 11, 2025
7c25c83
added changeset
franz101 Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cloudflare/src/cli/build/bundle-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export async function bundleServer(buildOpts: BuildOptions): Promise<void> {
// Apply updater updates, must be the last plugin
updater.plugin,
] as Plugin[],
external: ["./middleware/handler.mjs"],
external: ["./middleware/handler.mjs", "cloudflare:sockets", "cloudflare:email"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Would cloudflare:* work here ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should, also should it have node:*?

Copy link
Contributor

@vicb vicb Jun 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should, also should it have node:*?

That is taken care of by platform: "node",

But we should have tests for cloudflare:* :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how would you do this test?
open-next build worker.ts?

import "cloudflare:email";

export async function handler({
    return {}
}

alias: {
// Note: it looks like node-fetch is actually not necessary for us, so we could replace it with an empty shim
// but just to be safe we replace it with a module that re-exports the native fetch
Expand Down