feat(images): Implement local patterns for images

[sommeeeer]

fixes #731

[changeset-bot]

🦋 Changeset detected

Latest commit: 1316689

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@opennextjs/cloudflare	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@740

commit: 1316689

[vicb]

Thanks - you are on fire 🔥

I think there might be a bug when there is no local pattern?

[vicb]

not a 🦊 ??

[vicb]

Also would be nice to add tests from https://github.com/vercel/next.js/blob/canary/test/unit/image-optimizer/match-local-pattern.test.ts in images.spec.ts as we have for remote patterns.
Thx

[sommeeeer]

Alright, so I added a fix commit. Sorry about the confusion!

edit2: I guess we wrap pathname and hostname with makeRe() in our test cause Next uses the same when writing the manifest here? However, why does Next use it again inside matchRemotePattern() and matchLocalPattern()? They are also using the arrays from the config.

Say Hello to Snipp! She is the cutest most active cat on this planet. Unfortunently she got sold to a happy customer in London! I hope she is doing fine there (my family owns a cat breeding business 🐈).

[vicb]

However, why does Next use it again inside matchRemotePattern() and matchLocalPattern()?

Those methods are call from the image optimizer that passes in the next config and not the manifest

Snipp is so lovely 🥰

[vicb]

LGTM, thanks!

A couple more nits and should be good to 🚀

[vicb]

Awesome, thanks!