-
Notifications
You must be signed in to change notification settings - Fork 73
fix _next/image test #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix _next/image test #777
Conversation
|
commit: |
Root cause is fixed at cloudflare/workers-sdk#9935
Tests look good after updating Miniflare (via wrangler) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a test related to Next.js image handling by updating the wrangler dependency and simplifying test assertions. The changes address issues with _next/image
test behavior that was previously fixed in the upstream workers-sdk repository.
- Updates wrangler version from ^4.23.0 to ^4.24.4 to include upstream fixes
- Simplifies image request test to expect a specific 400 status code instead of multiple possible status codes
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
pnpm-workspace.yaml | Updates wrangler dependency version to include upstream fixes |
examples/playground14/e2e/cloudflare.spec.ts | Simplifies test assertion to expect only 400 status for disallowed image requests |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
examples/playground14/e2e/cloudflare.spec.ts:31
- The test now only checks for a 400 status code, but the removed comment suggests that a 403 status from the asset worker was also a valid response. Consider adding a comment explaining why only 400 is now expected, or verify that the upstream fix ensures consistent 400 responses.
expect(res.status()).toBe(400);
Thanks for the review |
Root cause is fixed at cloudflare/workers-sdk#9935
This PR should not be merged until the fix is released to miniflare