Skip to content

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jul 11, 2025

Root cause is fixed at cloudflare/workers-sdk#9935

This PR should not be merged until the fix is released to miniflare

Copy link

changeset-bot bot commented Jul 11, 2025

⚠️ No Changeset found

Latest commit: bd7884f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vicb vicb marked this pull request as draft July 11, 2025 12:13
Copy link

pkg-pr-new bot commented Jul 11, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@777

commit: bd7884f

@vicb vicb force-pushed the vicb/image-403 branch from 43706f3 to bd7884f Compare July 16, 2025 12:23
@vicb vicb marked this pull request as ready for review July 16, 2025 12:59
@vicb
Copy link
Contributor Author

vicb commented Jul 16, 2025

Tests look good after updating Miniflare (via wrangler)

@vicb vicb requested a review from Copilot July 16, 2025 12:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a test related to Next.js image handling by updating the wrangler dependency and simplifying test assertions. The changes address issues with _next/image test behavior that was previously fixed in the upstream workers-sdk repository.

  • Updates wrangler version from ^4.23.0 to ^4.24.4 to include upstream fixes
  • Simplifies image request test to expect a specific 400 status code instead of multiple possible status codes

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
pnpm-workspace.yaml Updates wrangler dependency version to include upstream fixes
examples/playground14/e2e/cloudflare.spec.ts Simplifies test assertion to expect only 400 status for disallowed image requests
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

examples/playground14/e2e/cloudflare.spec.ts:31

  • The test now only checks for a 400 status code, but the removed comment suggests that a 403 status from the asset worker was also a valid response. Consider adding a comment explaining why only 400 is now expected, or verify that the upstream fix ensures consistent 400 responses.
			expect(res.status()).toBe(400);

@vicb vicb requested review from conico974 and james-elicx July 16, 2025 13:00
@vicb
Copy link
Contributor Author

vicb commented Jul 16, 2025

Thanks for the review

@vicb vicb merged commit ea25f6a into main Jul 16, 2025
7 checks passed
@vicb vicb deleted the vicb/image-403 branch July 16, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants