Skip to content

Conversation

sommeeeer
Copy link
Collaborator

@sommeeeer sommeeeer commented Jul 16, 2025

For #667, #794 and #792.

This code in Next needs to be patched, and also loadManifest also needs to be patched. It will get a path for required-server-files.json and .next/BUILD_ID.

Tested on [email protected]

Update: This will make instrumenation and loadManifest work on >=15.4.2, but there is more patches that need update. Incremental Cache is not getting applied and possibly more issues. Needs more investigation.

Copy link

changeset-bot bot commented Jul 16, 2025

🦋 Changeset detected

Latest commit: a67f1e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jul 16, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@795

commit: a67f1e3

@sommeeeer sommeeeer requested review from conico974 and vicb July 16, 2025 13:30
@sommeeeer sommeeeer requested a review from conico974 July 17, 2025 09:12
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Does that fix at least some of the examples updated to 15.4.2?

It would be nice to add that info to the PR description

@sommeeeer
Copy link
Collaborator Author

sommeeeer commented Jul 20, 2025

Thanks for the review Victor!

Does that fix at least some of the examples updated to 15.4.2?

It does fix these patches for 15.4.2, but there is more patches that needs update. For the cache handler. You will get an error during runtime when you visit any route:

✘ [ERROR] Failed to update prerender cache for /index Error: [unenv] fs.mkdir is not implemented yet!
image

I havent figured out which part yet, but for some reason the incremental cache is not getting applied and I think this code from Next gets run. Needs further investigation.

@vicb
Copy link
Contributor

vicb commented Jul 20, 2025

I havent figured out which part yet, but for some reason the incremental cache is not getting applied and I think this code from Next gets run. Needs further investigation.

I think @conico974 told me some patches need to be updated for 15.4 to patch server/route-modules/route-module.ts instead.

Thanks for adding the info the PR description for now!

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sommeeeer !

@vicb vicb merged commit d18cd9d into opennextjs:main Jul 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants