-
Notifications
You must be signed in to change notification settings - Fork 73
fix(patches): Update patchInstrumentation and loadManifest to work with Next 15.4 #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix instr fix
🦋 Changeset detectedLatest commit: a67f1e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
packages/cloudflare/src/cli/build/patches/plugins/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/cloudflare/src/cli/build/patches/plugins/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/cloudflare/src/cli/build/patches/plugins/load-manifest.ts
Outdated
Show resolved
Hide resolved
packages/cloudflare/src/cli/build/patches/plugins/instrumentation.spec.ts
Outdated
Show resolved
Hide resolved
packages/cloudflare/src/cli/build/patches/plugins/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/cloudflare/src/cli/build/patches/plugins/instrumentation.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Does that fix at least some of the examples updated to 15.4.2?
It would be nice to add that info to the PR description
…t.ts Co-authored-by: Victor Berchet <[email protected]>
…ion.spec.ts Co-authored-by: Victor Berchet <[email protected]>
…ion.ts Co-authored-by: Victor Berchet <[email protected]>
Thanks for the review Victor!
It does fix these patches for
I havent figured out which part yet, but for some reason the incremental cache is not getting applied and I think this code from Next gets run. Needs further investigation. |
I think @conico974 told me some patches need to be updated for 15.4 to patch Thanks for adding the info the PR description for now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sommeeeer !
For #667, #794 and #792.
This code in Next needs to be patched, and also
loadManifest
also needs to be patched. It will get a path forrequired-server-files.json
and.next/BUILD_ID
.Tested on
[email protected]
Update: This will make instrumenation and loadManifest work on
>=15.4.2
, but there is more patches that need update. Incremental Cache is not getting applied and possibly more issues. Needs more investigation.