-
Notifications
You must be signed in to change notification settings - Fork 73
fix: wrangler config not passed to cache population #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: b5c74fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
18f5b1b
to
4397b51
Compare
Co-authored-by: Victor Berchet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, thanks for the fix!
We should get this in when the merge glitch is fixed.
There are 2 things we should look at for the CLI:
- this comment
- unify how we pass the env and config path to
runWrangler
(sometime viawranglerOpts
, sometimes directly in theargs
)
"lint": "next lint", | ||
"build:worker": "pnpm opennextjs-cloudflare build", | ||
"preview:worker": "pnpm opennextjs-cloudflare preview", | ||
"build:worker": "pnpm opennextjs-cloudflare build --skipWranglerConfigCheck", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we --skipWranglerConfigCheck
here?
Shouldn't we --config wrangler.e2e.jsonc
instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build doesn't need to know about the config, it just has a check at the end of running to see if one exists and prompts to let you create one if not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about initOpenNextCloudflareForDev();
but we can wait until we tackle this in a follow up PR
Agree we should look at both of those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
fixes #813