Skip to content

Conversation

james-elicx
Copy link
Collaborator

fixes #813

Copy link

changeset-bot bot commented Jul 24, 2025

🦋 Changeset detected

Latest commit: b5c74fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jul 24, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@814

commit: b5c74fa

@james-elicx james-elicx force-pushed the james/populate-config branch from 18f5b1b to 4397b51 Compare July 24, 2025 08:42
@james-elicx james-elicx marked this pull request as ready for review July 24, 2025 08:57
@james-elicx james-elicx requested a review from vicb July 24, 2025 08:57
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, thanks for the fix!

We should get this in when the merge glitch is fixed.

There are 2 things we should look at for the CLI:

  • this comment
  • unify how we pass the env and config path to runWrangler (sometime via wranglerOpts, sometimes directly in the args)

"lint": "next lint",
"build:worker": "pnpm opennextjs-cloudflare build",
"preview:worker": "pnpm opennextjs-cloudflare preview",
"build:worker": "pnpm opennextjs-cloudflare build --skipWranglerConfigCheck",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we --skipWranglerConfigCheck here?
Shouldn't we --config wrangler.e2e.jsonc instead ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build doesn't need to know about the config, it just has a check at the end of running to see if one exists and prompts to let you create one if not

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about initOpenNextCloudflareForDev(); but we can wait until we tackle this in a follow up PR

@james-elicx
Copy link
Collaborator Author

There are 2 things we should look at for the CLI:

  • this comment
  • unify how we pass the env and config path to runWrangler (sometime via wranglerOpts, sometimes directly in the args)

Agree we should look at both of those.

@james-elicx james-elicx requested a review from vicb July 24, 2025 09:34
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vicb vicb merged commit 89ce96b into main Jul 24, 2025
7 checks passed
@vicb vicb deleted the james/populate-config branch July 24, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] --config flag not passed to cache population when using preview command

2 participants