Skip to content

fix deploy and upload commands not taking into account environment variables #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2025
+12 −2
Merged

fix deploy and upload commands not taking into account environment variables #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c247859
fix `deploy` command not taking into account environment variables
dario-piotrowicz Jul 25, 2025
3624660
update upload command as well
dario-piotrowicz Jul 28, 2025
945f849
move logic inside `getDeploymentMapping`
dario-piotrowicz Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/legal-bags-agree.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@opennextjs/cloudflare": patch
---

fix `deploy` and `upload` commands not taking into account environment variables
9 changes: 7 additions & 2 deletions packages/cloudflare/src/cli/commands/skew-protection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,18 +45,23 @@ const MS_PER_DAY = 24 * 3600 * 1000;
*
* @param options Build options
* @param config OpenNext config
* @param envVars Environment variables
* @param workerEnvVars Worker Environment variables (taken from the wrangler config files)
* @returns Deployment mapping or undefined
*/
export async function getDeploymentMapping(
options: BuildOptions,
config: OpenNextConfig,
envVars: WorkerEnvVar
workerEnvVars: WorkerEnvVar
): Promise<Record<string, string> | undefined> {
if (config.cloudflare?.skewProtection?.enabled !== true) {
return undefined;
}

// Note that `process.env` is spread after `workerEnvVars` since we do want
// system environment variables to take precedence over the variables defined
// in the wrangler config files
const envVars = { ...workerEnvVars, ...process.env };

const nextConfig = loadConfig(path.join(options.appBuildOutputPath, ".next"));
const deploymentId = nextConfig.deploymentId;

Expand Down