Fix regional cache for the DOShardedTagCache #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 25, 2025 17:45
🦋 Changeset detectedLatest commit: a3e0889 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
vicb
reviewed
Jul 28, 2025
| return Math.max(...cachedValue.map((item) => item.time)); | ||
| } | ||
| // Otherwise we need to check the durable object on the ones that were not found in the cache | ||
| const filteredTags = tags.filter((tag) => !cachedValue.some((item) => item.tag === tag)); |
There was a problem hiding this comment.
Suggested change
| const filteredTags = tags.filter((tag) => !cachedValue.some((item) => item.tag === tag)); | |
| const filteredTags = deduplicatedTags.filter((tag) => !cachedValue.some((item) => item.tag === tag)); |
vicb
approved these changes
Jul 28, 2025
|
Could you please add a changeset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regional cache for the DOShardedTagCache.
I open it as a draft PR for now.
Fix #819
This implementation will store every single tag in their own cache entry.
I think we should add an option to the tag cache.It may make sense for some cases to store all the tag fromhasBeenRevalidatedin the same cache entry. It could be faster, but will likely ends up with less cache hit.After some thought, i don't think it's worth it, the only times where it could be useful would be if you don't use (or barely) the data cache, and that you have very few ISR/SSG cache entry. Maybe an improvement to do in another PR.