Skip to content

Conversation

james-elicx
Copy link
Collaborator

@james-elicx james-elicx commented Oct 9, 2024

Changes

  • Defaults the __OPENNEXT_KV_BINDING_NAME env var to the default kv name.
    • The typescript types mark this variable as defined due to its use for inlining in the cache handler, so defaulting the env var itself makes sense I think.
  • Uses the env var in the config for the kv name.
  • Adds more context to the cache handler patch.

docs pr: opennextjs/docs#24

Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: 7febc5d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 9, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@83

commit: 7febc5d

@james-elicx james-elicx marked this pull request as ready for review October 9, 2024 22:11
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks James!

@vicb vicb merged commit 87f4fb5 into main Oct 10, 2024
7 checks passed
@vicb vicb deleted the james/use-opennext-kv-var branch October 10, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants