-
Notifications
You must be signed in to change notification settings - Fork 73
Update the patches for Next 15.4 #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 1b77fd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
packages/cloudflare/src/cli/build/patches/plugins/route-module.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Victor Berchet <[email protected]>
packages/cloudflare/src/cli/build/patches/plugins/route-module.ts
Outdated
Show resolved
Hide resolved
packages/cloudflare/src/cli/build/patches/plugins/route-module.ts
Outdated
Show resolved
Hide resolved
This one is ready to go. There is atleast one more patch that needs update. If you build the It wont render the correct 500 html page either. |
packages/cloudflare/src/cli/build/patches/plugins/route-module.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @sommeeeer
fixes #667
Patch Next
>= 15.4
forgetIncrementalCache
in/next/src/server/route-modules/route-module.ts
Its pretty much the same as in the
next-server
patch, we just needed to update the rule and filter. These files were affected:We might also have to make a patch for
loadCustomCacheHandlers
in the same files, however from my testing it seems to be already initialized therefor it will early return and logcache handlers already initialized
if you enableNEXT_PRIVATE_DEBUG_CACHE=1
. From what I can see it gets initialized in NextServer'sloadCustomCacheHandlers
beforehand.