Ensure that the initial request.signal is passed to the wrapper #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 20730c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
james-elicx
approved these changes
Aug 13, 2025
|
Thanks for the review James! |
conico974
approved these changes
Aug 14, 2025
|
Hey, I'm back from vacation! Thanks @sommeeeer for working on this, I'll update aws soon. Can #847 be closed and this one used instead? |
vicb
reviewed
Aug 25, 2025
|
Welcome back @vicb ! Yeah, I'll close that one right now. |
|
Changes LGTM but we need to bump aws before merging this I think? |
|
Thanks for the review Victor. Yeah, it needs latest AWS |
vicb
force-pushed
the
for-request-signal-onabort
branch
from
618a3e7 to
98e6d7d
Compare
|
rebased on HEAD (aws 3.7.6) |
vicb
changed the title
vicb
reviewed
Sep 1, 2025
vicb
approved these changes
Sep 1, 2025
There was a problem hiding this comment.
Thanks for the update @sommeeeer, let's merge as CI gets green!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For opennextjs/opennextjs-aws#952
Pass along the original
AbortSignalto the wrapper.Will make
request.signal.onabortwork in route handlers.Should also close #691