Skip to content

perf: add an index on the tag column in D1 tag cache #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

perf: add an index on the tag column in D1 tag cache #898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/poor-points-work.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@opennextjs/cloudflare": patch
---

perf: add an index on the tag column in D1 tag cache

It only applies to newly created tables
2 changes: 1 addition & 1 deletion packages/cloudflare/src/api/overrides/tag-cache/d1-next-tag-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export class D1NextModeTagCache implements NextModeTagCache {
await db.batch(
tags.map((tag) =>
db
.prepare(`INSERT INTO revalidations (tag, revalidatedAt) VALUES (?, ?)`)
.prepare(`INSERT OR REPLACE INTO revalidations (tag, revalidatedAt) VALUES (?, ?)`)
.bind(this.getCacheKey(tag), Date.now())
)
);
Expand Down
2 changes: 1 addition & 1 deletion packages/cloudflare/src/cli/commands/populate-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ function populateD1TagCache(
[
"d1 execute",
D1_TAG_BINDING_NAME,
`--command "CREATE TABLE IF NOT EXISTS revalidations (tag TEXT NOT NULL, revalidatedAt INTEGER NOT NULL, UNIQUE(tag) ON CONFLICT REPLACE);"`,
`--command "CREATE TABLE IF NOT EXISTS revalidations (tag TEXT PRIMARY KEY, revalidatedAt INTEGER);"`,
`--preview ${populateCacheOptions.shouldUsePreviewId}`,
],
{
Expand Down
Loading