refactor: only try to purge the cache when invalidation is configured #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7148ae7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vicb
requested review from
conico974,
james-elicx,
dario-piotrowicz and
sommeeeer
and removed request for
conico974
commit: |
vicb
force-pushed
the
vicb/purge-if-enabled
branch
from
241bcfa to
155ad09
Compare
vicb
force-pushed
the
vicb/purge-if-enabled
branch
from
155ad09 to
7148ae7
Compare
james-elicx
approved these changes
Sep 25, 2025
|
Thanks James! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
purgeCacheByTagsis called whether or not the invalidation is configured.This result in logging an error when the invalidation is not configured.
This PR removes the error when the invalidation is not configured (calling
purgeCacheByTagsis a noop anyway).