Skip to content

fix: handle cases of chunked middleware #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2024
Merged

fix: handle cases of chunked middleware #2574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec5e1f5
test: make middleware fixture produce chunked middleware
pieh Aug 26, 2024
25cd319
fix: handle cases of chunked middleware
pieh Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/build/functions/edge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ const copyHandlerDependencies = async (
const entrypoint = await readFile(join(srcDir, file), 'utf8')
parts.push(`;// Concatenated file: ${file} \n`, entrypoint)
}
const exports = `export default _ENTRIES["middleware_${name}"].default;`
const exports = `const middlewareEntryKey = Object.keys(_ENTRIES).find(entryKey => entryKey.startsWith("middleware_${name}")); export default _ENTRIES[middlewareEntryKey].default;`
await mkdir(dirname(join(destDir, `server/${name}.js`)), { recursive: true })

await writeFile(join(destDir, `server/${name}.js`), [...parts, exports].join('\n'))
Expand Down
7 changes: 7 additions & 0 deletions tests/fixtures/middleware/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ const nextConfig = {
eslint: {
ignoreDuringBuilds: true,
},
webpack: (config) => {
// this is a trigger to generate multiple `.next/server/middleware-[hash].js` files instead of
// single `.next/server/middleware.js` file
config.optimization.splitChunks.maxSize = 100_000

return config
},
}

module.exports = nextConfig
Loading