ci: don't use next's github releases as source of most recent stable/canary versions #2686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
deleted the
ci/dont-use-next-github-release-as-source-of-stable-canary-versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our setup to run Vercel's tests seems to no longer work as expected now that
rcversion is not marked as "prerelease" in Github Releases (we are relying onprereleasestatus of Github release to select git tag forlatestandcanaryright now).See https://github.com/netlify/next-runtime/actions/runs/11432475420/job/31803013304 which is supposed to run against
latestbut it checks out following git tagnote: switching to 'refs/tags/v15.0.0-rc.1'.and later tries to install swc binaries for actual stable (pnpm add --workspace-root @next/[email protected]) so we might have some problems caused by version mismatch that our current setup is producing.This changes so we use
npmas sole source of truth and construct git tag from it instead (basically now git tag isv$(npm info next@<version_selector>)) and we don't check github releases at all now.I triggered workflow manually from my branch - https://github.com/netlify/next-runtime/actions/runs/11437943131 and it seems to work correctly there (also added
rcselector for this manual run - we might want to add it to our daily runs?)