Skip to content

chore: remove trailing slash logging (revert #2743) #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025
Merged

chore: remove trailing slash logging (revert #2743) #2805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e0e71b
chore: remove trailing slash logging (revert #2743)
mrstork Mar 31, 2025
3530ca2
Merge branch 'main' into remove-trailing-slash-logs
mrstork Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/run/handlers/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export default async (
})
}

setCacheControlHeaders(response, request, requestContext, nextConfig)
setCacheControlHeaders(response, request, requestContext)
setCacheTagsHeaders(response.headers, requestContext)
setVaryHeaders(response.headers, request, nextConfig)
setCacheStatusHeader(response.headers, nextCache)
Expand Down
10 changes: 1 addition & 9 deletions src/run/headers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { NextConfigComplete } from 'next/dist/server/config-shared.js'

import type { NetlifyCachedRouteValue, NetlifyCacheHandlerValue } from '../shared/cache-types.cjs'

import { getLogger, RequestContext } from './handlers/request-context.cjs'
import { RequestContext } from './handlers/request-context.cjs'
import { recordWarning } from './handlers/tracer.cjs'
import { getMemoizedKeyValueStoreBackedByRegionalBlobStore } from './storage/storage.cjs'

Expand Down Expand Up @@ -200,7 +200,6 @@ export const setCacheControlHeaders = (
{ headers, status }: Response,
request: Request,
requestContext: RequestContext,
nextConfig: NextConfigComplete,
) => {
if (
typeof requestContext.routeHandlerRevalidate !== 'undefined' &&
Expand All @@ -213,13 +212,6 @@ export const setCacheControlHeaders = (
return
}

// temporary diagnostic to evaluate number of trailing slash redirects
if (status === 308 && request.url.endsWith('/') !== nextConfig.trailingSlash) {
getLogger()
.withFields({ trailingSlash: nextConfig.trailingSlash, location: headers.get('location') })
.log('NetlifyHeadersHandler.trailingSlashRedirect')
}

const cacheControl = headers.get('cache-control')
if (status === 404) {
if (request.url.endsWith('.php')) {
Expand Down
Loading