fix: RSC responses when using middleware rewrites or redirects for cacheable page being served for html requests #2843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📊 Package size report 0.01%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
…cheable page being served for html requests
mrstork
approved these changes
Apr 15, 2025
pieh
deleted the
michalpiechowiak/frb-1745-next1530-and-middleware-rewrites-result-in-caching-and
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2827 change was insufficient. Middleware redirects and rewrites are stripping
_rscquery param while still usingRSCheader to produce flight data responses. This adds all the previously provided headers invaryto fix this case.This might be too broad overall and more iterations might be needed to scale down number of added variations, but it requires more investigation so this is meant as hot fix to prevent cache posioning until more research is done.
Tests
Added e2e tests - failing without any code changes - https://github.com/opennextjs/opennextjs-netlify/actions/runs/14473282580/job/40592531094?pr=2843
Relevant links (GitHub issues, etc.) or a picture of cute animal
https://linear.app/netlify/issue/FRB-1745/next1530-and-middleware-rewrites-result-in-caching-and-serving-rsc-for