Skip to content

test: add await to rejects.toThrowError statements #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2025
Merged

test: add await to rejects.toThrowError statements #3046

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82b273f
test: await rejects.toThrowError in tests
mrstork Aug 13, 2025
610d39b
Merge branch 'main' into await-to-throw-in-tests
serhalp Aug 13, 2025
1227fd2
Merge branch 'main' into await-to-throw-in-tests
mrstork Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/integration/simple-app.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,21 +149,21 @@ test<FixtureTestContext>('Test that the simple next app is working', async (ctx)
describe('verification', () => {
test<FixtureTestContext>("Should warn if publish dir doesn't exist", async (ctx) => {
await createFixture('simple', ctx)
expect(() => runPlugin(ctx, { PUBLISH_DIR: 'no-such-directory' })).rejects.toThrowError(
await expect(() => runPlugin(ctx, { PUBLISH_DIR: 'no-such-directory' })).rejects.toThrowError(
/Your publish directory was not found at: \S+no-such-directory. Please check your build settings/,
)
})

test<FixtureTestContext>('Should warn if publish dir is root', async (ctx) => {
await createFixture('simple', ctx)
expect(() => runPlugin(ctx, { PUBLISH_DIR: '.' })).rejects.toThrowError(
await expect(() => runPlugin(ctx, { PUBLISH_DIR: '.' })).rejects.toThrowError(
'Your publish directory cannot be the same as the base directory of your site. Please check your build settings',
)
})

test<FixtureTestContext>('Should warn if publish dir is root (package path variant)', async (ctx) => {
await createFixture('simple', ctx)
expect(() =>
await expect(() =>
runPlugin(ctx, { PUBLISH_DIR: 'app/.', PACKAGE_PATH: 'app' }),
).rejects.toThrowError(
'Your publish directory cannot be the same as the base directory of your site. Please check your build settings',
Expand All @@ -172,7 +172,7 @@ describe('verification', () => {

test<FixtureTestContext>('Should warn if publish dir is not set to Next.js output directory', async (ctx) => {
await createFixture('simple', ctx)
expect(() => runPlugin(ctx, { PUBLISH_DIR: 'public' })).rejects.toThrowError(
await expect(() => runPlugin(ctx, { PUBLISH_DIR: 'public' })).rejects.toThrowError(
'Your publish directory does not contain expected Next.js build output. Please check your build settings',
)
})
Expand Down
Loading