Skip to content

test: skip more tests that don't exactly match status code due to platform differences #3077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2025
Merged

test: skip more tests that don't exactly match status code due to platform differences #3077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/test-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,14 @@
"app-dir action size limit invalid config should respect the size set in serverActions.bodySizeLimit for plaintext fetch actions should error for requests that exceed the size limit",
"app-dir action size limit invalid config should respect the size set in serverActions.bodySizeLimit for multipart fetch actions should error for requests that exceed the size limit"
]
},
{
"file": "test/e2e/app-dir/actions/app-action-size-limit-invalid-node-middleware.test.ts",
"reason": "Mismatch of reported status code of response (502 instead of expected 500)",
"tests": [
"app-dir action size limit invalid config should respect the size set in serverActions.bodySizeLimit for plaintext fetch actions should error for requests that exceed the size limit",
"app-dir action size limit invalid config should respect the size set in serverActions.bodySizeLimit for multipart fetch actions should error for requests that exceed the size limit"
]
Comment on lines +416 to +422
Copy link
Contributor Author

@pieh pieh Aug 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty much the same as previous entry, just this test suite was using node middleware while previous test suite was using edge middleware

FAIL default test/e2e/app-dir/actions/app-action-size-limit-invalid-node-middleware.test.ts (137.775 s)
  app-dir action size limit invalid config
    should respect the size set in serverActions.bodySizeLimit for plaintext fetch actions
      ✓ should not error for requests that stay below the size limit (2461 ms)
      ✕ should error for requests that exceed the size limit (710 ms)
    should respect the size set in serverActions.bodySizeLimit for multipart fetch actions
      ✓ should not error for requests that stay below the size limit (8847 ms)
      ✓ should not error for requests that are at the size limit (1548 ms)
      ✕ should error for requests that exceed the size limit (1078 ms)

  ● app-dir action size limit invalid config › should respect the size set in serverActions.bodySizeLimit for plaintext fetch actions › should error for requests that exceed the size limit

    expect(received).toBe(expected) // Object.is equality

    Expected: 500
    Received: 502

    �[0m �[90m 137 |�[39m         { request�[33m:�[39m { method�[33m:�[39m �[32m'POST'�[39m�[33m,�[39m pathname�[33m:�[39m �[32m'/file'�[39m } }
     �[90m 138 |�[39m       )
    �[31m�[1m>�[22m�[39m�[90m 139 |�[39m       expect(actionResponse�[33m.�[39mstatus())�[33m.�[39mtoBe(�[35m500�[39m) �[90m// TODO: 413?�[39m
     �[90m     |�[39m                                       �[31m�[1m^�[22m�[39m
     �[90m 140 |�[39m       expect(
     �[90m 141 |�[39m         �[36mawait�[39m actionResponse�[33m.�[39mrequest()�[33m.�[39mheaderValue(�[32m'content-type'�[39m)
     �[90m 142 |�[39m       )�[33m.�[39mtoStartWith(�[32m'text/plain'�[39m)�[0m

      at Object.toBe (e2e/app-dir/actions/app-action-size-limit-invalid.test.ts:139:39)

  ● app-dir action size limit invalid config › should respect the size set in serverActions.bodySizeLimit for multipart fetch actions › should error for requests that exceed the size limit

    expect(received).toBe(expected) // Object.is equality

    Expected: 500
    Received: 502

    �[0m �[90m 226 |�[39m         { request�[33m:�[39m { method�[33m:�[39m �[32m'POST'�[39m�[33m,�[39m pathname�[33m:�[39m �[32m'/form'�[39m } }
     �[90m 227 |�[39m       )
    �[31m�[1m>�[22m�[39m�[90m 228 |�[39m       expect(actionResponse�[33m.�[39mstatus())�[33m.�[39mtoBe(�[35m500�[39m) �[90m// TODO: 413?�[39m
     �[90m     |�[39m                                       �[31m�[1m^�[22m�[39m
     �[90m 229 |�[39m       expect(
     �[90m 230 |�[39m         �[36mawait�[39m actionResponse�[33m.�[39mrequest()�[33m.�[39mheaderValue(�[32m'content-type'�[39m)
     �[90m 231 |�[39m       )�[33m.�[39mtoStartWith(�[32m'multipart/form-data'�[39m)�[0m

      at Object.toBe (e2e/app-dir/actions/app-action-size-limit-invalid.test.ts:228:39)

}
],
"failures": [
Expand Down
Loading