Skip to content

test: skip tests #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pieh merged 7 commits into from
Sep 15, 2025
Merged

test: skip tests #3116

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2af4aa1
test: skip test asserting specific 404 body that does not match Netli…
pieh Sep 11, 2025
77a0c9b
test: skip test that gets stuck on page.waitForLoadState('networkidle')
pieh Sep 11, 2025
cd03dbc
test: skip test that relies on x-vercel-cache response header
pieh Sep 11, 2025
64f777d
chore: format
pieh Sep 11, 2025
e769b99
test: don't skip 404 body tests after revert
pieh Sep 14, 2025
3e0ff1f
Merge remote-tracking branch 'origin/main' into e2e-test-skips
pieh Sep 14, 2025
0c93b4c
Merge branch 'main' into e2e-test-skips
pieh Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions tests/test-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,47 @@
{
"file": "test/e2e/app-dir/fallback-shells/fallback-shells.test.ts",
"reason": "Test relies on x-matched-path response header that is not set in non-minimal mode"
},
{
"file": "test/e2e/invalid-static-asset-404-pages/invalid-static-asset-404-pages.test.ts",
"reason": "We are serving default Netlify 404 page instead of relying on next-server to serve 404 (https://github.com/opennextjs/opennextjs-netlify/pull/3100)",
"tests": [
"invalid-static-asset-404-pages should return 404 with plain text when fetching invalid asset path"
]
},
{
"file": "test/e2e/invalid-static-asset-404-pages/invalid-static-asset-404-pages-base-path.test.ts",
"reason": "We are serving default Netlify 404 page instead of relying on next-server to serve 404 (https://github.com/opennextjs/opennextjs-netlify/pull/3100)",
"tests": [
"invalid-static-asset-404-pages-base-path should return 404 with plain text when fetching invalid asset path"
]
},
{
"file": "test/e2e/invalid-static-asset-404-app/invalid-static-asset-404-app-base-path.test.ts",
"reason": "We are serving default Netlify 404 page instead of relying on next-server to serve 404 (https://github.com/opennextjs/opennextjs-netlify/pull/3100)",
"tests": [
"invalid-static-asset-404-app-base-path should return 404 with plain text when fetching invalid asset path"
]
},
{
"file": "test/e2e/invalid-static-asset-404-app/invalid-static-asset-404-app.test.ts",
"reason": "We are serving default Netlify 404 page instead of relying on next-server to serve 404 (https://github.com/opennextjs/opennextjs-netlify/pull/3100)",
"tests": [
"invalid-static-asset-404-app should return 404 with plain text when fetching invalid asset path"
]
},
{
"file": "test/e2e/app-dir/rsc-redirect/rsc-redirect.test.ts",
"reason": "page.waitForLoadState('networkidle') not resolving",
"tests": [
"rsc-redirect /old-about -> /about (ppr: false, segmentCache: true) uses prefetched, redirected URL in the navigation, as opposed to the href in the link",
"rsc-redirect /old-about -> /about (ppr: false, segmentCache: false) uses prefetched, redirected URL in the navigation, as opposed to the href in the link"
]
},
Comment on lines +451 to +458
Copy link
Contributor Author

@pieh pieh Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test failure or rather timeout is confusing. Test get stuck on

page.waitForLoadState('networkidle')

usage of which is strongly discouraged:

'networkidle' - DISCOURAGED wait until there are no network connections for at least 500 ms. Don't use this method for testing, rely on web assertions to assess readiness instead.

The test does pass if I replace that with couple seconds of just sleeping, but that's not something we can change so skipping it here.

I did try to debug this test on what keeps it stuck, but all the initiated requests finish and I so no network activity that could be keeping it stuck 🤷

{
"file": "test/e2e/app-dir/sub-shell-generation-middleware/sub-shell-generation-middleware.test.ts",
"reason": "Checking Vercel specific x-vercel-cache header",
"tests": ["middleware-static-rewrite should eventually result in a cache hit"]
}
Comment on lines +459 to 463
Copy link
Contributor Author

@pieh pieh Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was recently added

],
"failures": [
Expand Down
Loading