fix: produce relative redirect location url for same origin #3129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📊 Package size report 0%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
added
test all versions
pieh
commented
Sep 16, 2025
| return | ||
| } | ||
| edgeResponse.headers.set('location', redirect) | ||
| edgeResponse.headers.set('location', relativizeURL(redirect, request.url)) |
Contributor
Author
There was a problem hiding this comment.
Note: if redirect target is external, the location will remain absolute - relativeURL only make it relative if origin/host of redirect and request.url matches
opennextjs-netlify/edge-runtime/lib/util.ts
Lines 85 to 92 in c29381e
Added some unit tests for this in dbde615
pieh
commented
Sep 16, 2025
| expect(response.headers.get('location'), 'added a location header').toBeTypeOf('string') | ||
| expect( | ||
| new URL(response.headers.get('location') as string).pathname, | ||
| new URL(response.headers.get('location') as string, 'http://n').pathname, |
Contributor
Author
There was a problem hiding this comment.
Added base here (and few other tests) because relative location without it just fails to construct URL object and throws Invalid URL. We do assert on pathname URL portion anyway so base will be discarded on actual assertion
mrstork
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is not really fixing something currently not behaving correctly, but brings our middleware redirect handling closer to behavior on Vercel where "local" redirect doesn't result in
locationredirect header being absolute