[fix] externalSecret configuration in openfga-deployment.yaml #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configuration in openfga-deployment.yaml Previously, the `ENV` parameter `OPENFGA_DATASTORE_URI ` would be set, regardless of the `externalSecret.enabled` value, which would override the secret reference and prevent successful db authentication. The fix makes sure that the `ENV` parameter will only be set, if `externalSecret.enabled` is set to `false`.
kayahk
changed the title
|
@prabhatsharma Kindly review this PR and get this moving. |
prabhatsharma
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: conditionally set OPENFGA_DATASTORE_URI based on externalSecret configuration in openfga-deployment.yaml
Previously, the
ENVparameterOPENFGA_DATASTORE_URIwould be set, regardless of theexternalSecret.enabledvalue, which would override the secret reference and prevent successful db authentication.The fix makes sure that the
ENVparameter will only be set, ifexternalSecret.enabledis set tofalse.#139