Optimize tool-ui message checks in assistant hook (#1835) #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the sendAutomaticallyWhen logic in the assistant UI chat hook by checking all messages for tool-ui outputs rather than only examining the last message.
Changes:
- Refactored message checking logic from inspecting only the last message to iterating through all messages using
some()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+284
to
291
| return messages.some((message) => | ||
| message?.parts?.some( | ||
| (part) => | ||
| part?.type?.includes('tool-ui') && | ||
| 'output' in part && | ||
| !!part.output, | ||
| ), | ||
| ); |
There was a problem hiding this comment.
Checking all messages and all parts on every invocation could be inefficient as the message history grows. Consider tracking tool-ui state separately or limiting the search to recent messages if the intention is to detect new tool-ui outputs rather than any historical ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OPS-3293.