Rerun on latest version creates a new run #1862
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where retrying a flow run on the latest version was incorrectly updating the existing run instead of creating a new one. The fix changes the backend logic to duplicate the flow run with the updated version and updates the frontend to refresh the runs list after retry.
Changes:
- Backend service now creates a new flow run instead of updating the existing one when retrying on latest version
- Frontend refetch functionality added to refresh runs table after retry operation
- Function renamed from
updateFlowRunToLatestFlowVersionIdAndReturnPayloadtoduplicateFlowRunWithUpdatedVersionto reflect new behavior
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/server/api/src/app/flows/flow-run/flow-run-service.ts | Changed retry logic to create a new flow run instead of updating existing one |
| packages/react-ui/src/app/routes/runs/index.tsx | Added refetch prop to runs table columns |
| packages/react-ui/src/app/features/home/runs-table/runs-table.tsx | Passed refetch function to table columns |
| packages/react-ui/src/app/features/home/lib/home-hooks.ts | Exposed refetchRuns function from dashboard data hook |
| packages/react-ui/src/app/features/home/components/home-operational-view.tsx | Passed refetch function to HomeRunsTable component |
| packages/react-ui/src/app/features/flow-runs/hooks/useRunsTableColumns.tsx | Updated retry success handler to refetch runs instead of updating row in place |
Comments suppressed due to low confidence (1)
packages/react-ui/src/app/features/flow-runs/hooks/useRunsTableColumns.tsx:239
- The useMemo dependency array should include 'durationEnabled' and 'refetch' since these values affect the memoized columns. Missing dependencies can lead to stale closures and incorrect behavior when these values change.
[mutate, stopRun],
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OPS-2602.