Fix analytics route redirecting users during initial metadata load #1863
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition where users were being redirected away from the analytics route before user metadata finished loading. The fix introduces proper loading state handling by checking if metadata is still being fetched before making access control decisions.
Changes:
- Modified
useHasAnalyticsAccesshook to return both access state and loading status - Added loading spinner display in
AnalyticsGuardwhile metadata is being fetched - Updated
useUserMetahook to expose pending state
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react-ui/src/app/common/hooks/analytics-hooks.ts | Changed return type from boolean to object containing both access flag and pending state |
| packages/react-ui/src/app/common/hooks/user-hooks.ts | Added isPending field to return value for tracking query state |
| packages/react-ui/src/app/routes/openops-analytics/analytics-guard.tsx | Added loading state check and full-page spinner during metadata fetch |
| packages/react-ui/src/app/features/navigation/lib/menu-links-hook.ts | Updated to destructure hasAnalyticsAccess from new object return type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const { data: isAnalyticsEnabled } = flagsHooks.useFlag<boolean | undefined>( | ||
| FlagId.ANALYTICS_ENABLED, | ||
| ); |
There was a problem hiding this comment.
The feature flag loading state is not considered. If the flag is still loading, isAnalyticsEnabled will be undefined, causing isPending to be false while access decisions are made with incomplete data. Consider also checking the pending state from useFlag.
Fixes OPS-3457.