Fix slack connection #1864
Fix slack connection #1864
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the Slack OAuth2 connection flow by implementing a state parameter with BroadcastChannel for secure communication between the OAuth popup and the parent window.
Changes:
- Added state parameter generation and validation to the OAuth2 flow
- Implemented BroadcastChannel as the primary communication method with postMessage fallback
- Refactored the
getCodefunction to handle both communication mechanisms with proper cleanup
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| }; | ||
| } catch { | ||
| console.warn('BroadcastChannel not supported...'); |
There was a problem hiding this comment.
The error message 'BroadcastChannel not supported...' with trailing ellipsis is vague and doesn't inform the user about fallback behavior. Consider changing to something like 'BroadcastChannel not supported, falling back to postMessage' to clarify that the functionality will still work.
| console.warn('BroadcastChannel not supported...'); | |
| console.warn('BroadcastChannel not supported, falling back to postMessage'); |
|
Fixes OPS-3453
Use state param with BroadcastChannel to intercept the payload we need to store in the form