Skip to content

Conversation

@Banalian
Copy link
Contributor

This endpoint used to return an array, but now returns an object with an error and a message.

Note regarding the example: I'm not knowledgable enough to know if I should obfuscate that traceID. I doubt that it's important, but I'm mentioning it in case someone has a better idea.

This endpoint used to return an array, but now returns an object with an error and a message.
@codecat
Copy link
Member

codecat commented Aug 31, 2025

The trace ID should be fine. Do we need to update this for any other endpoints?

@Banalian
Copy link
Contributor Author

Banalian commented Sep 1, 2025

Aditional checks I made on the maps endoints

add fav with a wrong id : empty response with a 204 No content code (same as a valid map id)
remove fav: also always returns a 204 with no content, with a valid and invalid id.

I can go update these pages too, let me just navigate github's ui to do it in this PR on the web

Copy link
Member

@davidbmaier davidbmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, just cleaned up the phrasing a little 👍
Hope I didn't mix anything up while rephrasing, otherwise feel free to open a separate PR to clean it up.

@davidbmaier davidbmaier merged commit e0c0d29 into openplanet-nl:main Sep 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants