Skip to content

able to resize the uploaded image when its size is larger than assigned(fixes #3561) #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acckkiie wants to merge 1 commit into
base: stable-3.8.x
Choose a base branch
from
Open

able to resize the uploaded image when its size is larger than assigned(fixes #3561) #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions config/OpenPNE.yml.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,9 @@ ssl_selectable_actions:
# 2: on - JEPG,PNG,GIF に ImageMagick を使う (ただし、 GD も必要) (Use ImageMagick for JPEG,PNG,GIF)
use_imagemagick: 0

# DBに置くことができる画像の最大容量(byte)
resize_limit_size: 8192

# ImageMagick コマンドのパス
# Path to ImageMagick binary
imagemagick_path: '/usr/bin/convert'
Expand Down
68 changes: 65 additions & 3 deletions lib/model/doctrine/File.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,18 +57,80 @@ public function setFromValidatedFile(sfValidatedFile $obj)
$this->setFileBin($bin);
}

public function save(Doctrine_Connection $conn = null)
private function resizeImage($ratio, $image, $x, $y)
{
$this->setFilesize(strlen($this->FileBin->bin));
$type = $this->getType();
$resizex = $x*$ratio;
$resizey = $y*$ratio;
$resize = imagecreatetruecolor($resizex, $resizey);
switch($type)
{
case 'image/jpeg':
imagecopyresampled($resize, $image, 0, 0, 0, 0, $resizex, $resizey, $x, $y);
ob_start();
imagejpeg($resize);
break;
case 'image/gif':
$alpha = imagecolortransparent($image);
$trnprt_color = imagecolorsforindex($image, $alpha);
$alpha = imagecolorallocate($resize, $trnprt_color['red'], $trnprt_color['green'], $trnprt_color['blue']);
imagefill($resize, 0, 0, $alpha);
imagecolortransparent($resize, $alpha);
imagecopyresampled($resize, $image, 0, 0, 0, 0, $resizex, $resizey, $x, $y);
ob_start();
imagegif($resize);
break;
case 'image/png':
imagealphablending($resize, false);
imagesavealpha($resize, true);
imagecopyresampled($resize, $image, 0, 0, 0, 0, $resizex, $resizey, $x, $y);
ob_start();
imagepng($resize);
break;
default:
break;
}
$ei = ob_get_contents();
ob_end_clean();
imagedestroy($image);
imagedestroy($resize);

return $ei;
}

private function measuredImage($uploadimage, $filesize)
{
$ratio = sqrt($uploadimage/$filesize)/1.5;
$image = imagecreatefromstring($this->FileBin->bin);
$x = imagesx($image);
$y = imagesy($image);
$ei = $this->resizeImage($ratio, $image, $x, $y);

return $ei;
}

private function contractedImage()
{
$uploadimage = sfConfig::get('op_resize_limit_size', 1024);
$filesize = strlen($this->FileBin->bin);
if ($filesize > $uploadimage)
{
$ei = $this->measuredImage($uploadimage, $filesize);
$this->getFileBin()->setBin($ei);
}
}

public function save(Doctrine_Connection $conn = null)
{
if ($this->isImage())
{
$class = sfImageHandler::getStorageClassName();
$this->setName(call_user_func(array($class, 'getFilenameToSave'), $this->getName()), $class);

$storage = call_user_func(array($class, 'create'), $this, $class);
$this->contractedImage();
$storage->saveBinary($this->getFileBin());
}
$this->setFilesize(strlen($this->FileBin->bin));

return parent::save($conn);
}
Expand Down