Skip to content

Adding sig fig support#588

Merged
pwdel merged 6 commits intomainfrom
fix/decimal-places
Nov 11, 2025
Merged

Adding sig fig support#588
pwdel merged 6 commits intomainfrom
fix/decimal-places

Conversation

@astrosnat
Copy link
Collaborator

This is a preliminary look at adding significant figure support.

ChatGPT has made some changes on the backend in preparation for being able to add support for number of sig figs in charts. Looking for sanity checks if there's a saner/cleaner way to do this.

jordangeorge and others added 6 commits October 25, 2025 23:18
Adding a checkpoint for step by step implementation of a solution that allows users to change the number of significant figures in setup.yaml and changes the number of significant figures shown when mousing over the stepped chart
Sig fig support added on backend
@astrosnat astrosnat requested review from pwdel and raisch November 7, 2025 06:51
@astrosnat astrosnat self-assigned this Nov 7, 2025
@astrosnat astrosnat marked this pull request as draft November 7, 2025 06:51
}
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a general note, I have this MR going and am specifically avoiding setup as a handler for now.

I think we can probably turn setup into a library down the line?

So all of this to say, I think we're clear for now.

https://github.com/openpredictionmarkets/socialpredict/pull/581/files#diff-571e949aa3499ab87b5b9204758e78aa2dc527463bd5d3e93e958093090431d7

buySharesFee: 0
sellSharesFee: 0

frontend:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this proper yaml? I think we should have the frontend be called perhaps something like frontend setup and ideallly everything will be under the same header?

I guess it's a philosophical issue...maybe frontend is it's own category? Thoughts @astrosnat ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like real yaml to me.

I don't have strong thoughts on whether we should do backend + frontend yaml files as one big file or as 2 separate files...my feeling is that it's more user friendly to have it as one file, even if it's a bit uglier. What are your thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can just approve it and we can revisit this

@pwdel pwdel marked this pull request as ready for review November 11, 2025 01:34
@pwdel pwdel merged commit 2a93a41 into main Nov 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants