Fix developer extension version reporting#1024
Open
prettybits wants to merge 3 commits intoopenpreserve:integrationfrom
Open
Fix developer extension version reporting#1024prettybits wants to merge 3 commits intoopenpreserve:integrationfrom
prettybits wants to merge 3 commits intoopenpreserve:integrationfrom
Conversation
…on as a noteworthy case
…ck to trigger PDF-HUL-88 as intended
Member
|
Thanks for this @prettybits. My thoughts are:
That sounds like quite a bit once it's all done. Do you want to move this forward or should I look at then next tasks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #890
This fixes an exception that's surfaced when using the JSON handler with PDFs that list extensions in the document catalog. In this case, the parsed
Doublevalue of the extension'sBaseVersionkey was wrongly used for aStringproperty. I also noticed that the version strings were parsed outside thetry-block here, so the exception handling to report PDF-HUL-88 for extension's base versions didn't work as intended, this is also fixed.While here, I noticed that extension base versions are checked whether they are the same as the file's PDF version to report an info message for PDF-HUL-87, equivalently to the reporting for mismatching document info version compared to the file header. Since Extension's
BaseVersion"reflect the version of the standard that has been extended and not the version of this particular file" (see chapter 7.12.4 of the PDF specification) they need to be handled a bit differently. I aligned the check to not report anything for base versions lower than the PDF version as this is expected and only look for the case where the version is higher. Reporting PDF-HUL-87 for this case doesn't really fit then and would need a new error ID, I wasn't sure how to best go about introducing one. What do you think, @carlwilson?