Update scprint

[jkobject]

update scprint to v2.3.5

[rcannood]

LGTM! Thanks for improving the scprint component!

[rcannood]

@mumichae Can this be merged?

[mumichae]

I noticed that the preprocessing is inconsistent compared to all the other integration method, since you're not taking the HVGs that have been provided and likely do your own preprocessing and feature selection via scdataloader.Prreprocessor. I opened a new issue for that: #81

[lazappi]

Made some minor comments

I noticed that the preprocessing is inconsistent compared to all the other integration method, since you're not taking the HVGs that have been provided and likely do your own preprocessing and feature selection via scdataloader.Prreprocessor. I opened a new issue for that: #81

I think the preprocessor is just checking that enough genes are present, not doing feature selection, and that removing features would be bad for the model. But I suggest you discuss with @jkobject on #81.

[mumichae]

I think the preprocessor is just checking that enough genes are present, not doing feature selection, and that removing features would be bad for the model. But I suggest you discuss with @jkobject on #81.

Thanks Luke. If that's the case, then it's all good on my side 👍

@lazappi Can this be merged?

[lazappi]

I think so if you're happy with it

[jkobject]

@lazappi btw I have a good docker image for scGPT with flashattention for the grn_inference benchmark, do you want it for the other ones?

[lazappi]

@jkobject If you want to open some PRs that would be helpful. I think the scGPT components need an update anyway.