Skip to content

adding scprint#17

Closed
jkobject wants to merge 4 commits intoopenproblems-bio:mainfrom
jkobject:main
Closed

adding scprint#17
jkobject wants to merge 4 commits intoopenproblems-bio:mainfrom
jkobject:main

Conversation

@jkobject
Copy link

Describe your changes

copied a very similar workflow to scprint batch integration task since they are almost the same

@jkobject
Copy link
Author

jkobject commented Mar 10, 2025

@lazappi getting an issue here even when just building the tool

Doing: viash ns build --parallel or viash run src/methods/scprint/config.vsh.yaml -- --input resources_test/task_dimensionality_reduction/cxg_mouse_pancreas_atlas/dataset.h5ad --output reduced.h5ad

getting:

viash: Missing resource /home/ml4ig1/task_dimensionality_reduction/target/executable/methods/scprint/read_anndata_partial.py as specified in file:///home/ml4ig1/task_dimensionality_reduction/

@jkobject
Copy link
Author

I found the solution

@jkobject
Copy link
Author

Just FYI, resources_test/task_dimensionality_reduction/cxg_mouse_pancreas_atlas/dataset.h5ad doesn't contain a .uns["dataset_organism"]


runners:
- type: executable
docker_run_args: --gpus all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to remove this for the checks to pass

@lazappi
Copy link
Member

lazappi commented Mar 11, 2025

@jkobject Thanks for the contribution! However, this tasks is specifically dimensionality reduction for 2D visualisation so I don't think scPRINT is appropriate here. It's meant to evaluate methods like UMAP rather than big embedding models. Sorry for not realising earlier, I got mixed up with the PRs on other tasks.

@jkobject
Copy link
Author

OKay, makes sense. I wasn't sure actually.

@jkobject jkobject closed this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants