bugfix: mark committed to false only when it is nil in conn#80
Open
taoky wants to merge 1 commit intoopenresty:masterfrom
Open
bugfix: mark committed to false only when it is nil in conn#80taoky wants to merge 1 commit intoopenresty:masterfrom
taoky wants to merge 1 commit intoopenresty:masterfrom
Conversation
77374a3 to
574f0bb
Compare
zhuizhuhaomeng
requested changes
Feb 2, 2025
| committed: true | ||
| 6: 1, conn: 3 | ||
| committed: false | ||
| committed: true |
Contributor
There was a problem hiding this comment.
The changes do not follow the document.
https://github.com/openresty/lua-resty-limit-traffic/pull/80/files#diff-aa64cd78441de2bae2f552bca126b6cedde9a9fa7ba046d689386cbffecc5795R229
Author
There was a problem hiding this comment.
Well, I doubt if this change makes sense for is_committed() docs:
- Returns `true` if the previous [incoming](#incoming) call actually commits the event
+ Returns `true` if the previous [incoming](#incoming) calls actually have committed the event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When debugging the conn limiter today, I tried with this code in development env, to help me get conn counter value in HTTP header:
And surprised by that, after I added the
limiter:incoming(keys[i], false)here, thelimiter:is_committed()returns false even when it is actually committed.In
conn.md, it says:But it is actually not just "dry run" --
incomingwould always set committed to false at first not matter what.This PR tries to fix the lua code to align with docs, and adds a testcase for that.