Simplify ChangeDependency duplicates following openrewrite/rewrite#6406

[timtebeek]

• Following Avoid duplicate dependencies following one or more ChangeDependency recipes rewrite#6406
• And Tests for duplicate dependencies rewrite-java-dependencies#165
• and Update version in the Gradle model rewrite#6428

[timtebeek]

@BoykoAlex a quick headsup that for some reason I'm not yet seeing the effects you were after for Gradle. Just in case you run into it there as well.

[BoykoAlex]

Hmm... if there is a quick unit test you could drop in rewrite-gradle as a PR i could have a look at this issue...
(There is a test I added for Gradle but it is probably not covering everything)

[timtebeek]

Sure; in rewite-gradle that would be

    @Test
    void noDuplicateJacksonDatabindDependenciesInGradle() {
        rewriteRun(
          spec -> spec.beforeRecipe(withToolingApi())
            .recipes(
              new ChangeDependency(
                "com.fasterxml.jackson.core",
                "jackson-databind",
                "tools.jackson.core",
                null,
                "3.0.x",
                null,
                null,
                null
              ),
              new ChangeDependency(
                "com.fasterxml.jackson.datatype",
                "jackson-datatype-jsr310",
                "tools.jackson.core",
                "jackson-databind",
                "3.0.x",
                null,
                null,
                null
              )
            ),
          buildGradle(
            //language=gradle
            """
              plugins {
                  id("java-library")
              }
              repositories {
                  mavenCentral()
              }
              dependencies {
                  implementation("com.fasterxml.jackson.core:jackson-databind:2.19.0")
                  implementation("com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.19.0")
              }
              """,
            spec -> spec.after(buildGradle ->
              assertThat(buildGradle)
                .doesNotContain("jackson-datatype")
                .containsOnlyOnce("jackson-databind")
                .actual())
          )
        );
    }

Which fails with

java.lang.AssertionError: 
Expecting actual:
  "jackson-databind"
to appear only once in:
  "plugins {
    id("java-library")
}
repositories {
    mavenCentral()
}
dependencies {
    implementation("tools.jackson.core:jackson-databind:3.0.3")
    implementation("tools.jackson.core:jackson-databind:3.0.3")
}"
but it appeared 2 times 

[BoykoAlex]

This helps:

• Update version in the Gradle model rewrite#6428

However, I'm somewhat uncomfortable about computing resolvedVersion for every config... wonder if this needed at all. Wonder what would be the argument against keeping one cached resolvedVersion for all configs...

[timtebeek]

Great to see this simplification; thanks again @BoykoAlex ! And best wishes for the new year. :)