Skip to content

Conversation

@kdombeck
Copy link
Contributor

@kdombeck kdombeck commented Dec 24, 2025

to tools.jackson.(jaxrs,jakarta.rs,jr)

What's changed?

Migrate the following dependencies

What's your motivation?

This "should" complete all Jackson dependencies

Anything in particular you'd like reviewers to focus on?

Would you like me to merge these tests and others in this test class to use a single test with something like @MethodSource so that there is even less code to maintain?

Example:

@ParameterizedTest
@MethodSource("provideDependencyData")
void dependenciesMigrated(String groupId, String artifact, String expectedGroupId) {
...
}

static Stream<Arguments> provideDependencyData() {
    return Stream.of(
        Arguments.of("com.fasterxml.jackson.jaxrs", "jackson-jaxrs-base", "tools.jackson.jaxrs"),
...
        Arguments.of("com.fasterxml.jackson.jakarta.rs", "jackson-jakarta-rs-base", "tools.jackson.jakarta.rs"),
        Arguments.of("com.fasterxml.jackson.jakarta.rs", "jackson-jakarta-rs-cbor-provider", "tools.jackson.jakarta.rs"),
    );
}

Anyone you would like to review specifically?

@timtebeek

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

…ndencies

to tools.jackson.(jaxrs,jakarta.rs,jr)
Copy link
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot! Had no idea there were so many Jackson dependencies. 😅

Would you like me to merge these tests and others in this test class to use a single test with something like @MethodSource so that there is even less code to maintain?

No perfect as is; don't mind a bit of repetition for clarity here; good to see these covered too!

Enjoy the holidays there, and thanks again for pitching in here.

@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in OpenRewrite Dec 24, 2025
@timtebeek timtebeek merged commit f6c7a2f into openrewrite:main Dec 24, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Dec 24, 2025
@kdombeck kdombeck deleted the jackson-jaxrs-jakarta-jr branch December 24, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants