Skip to content
This repository was archived by the owner on Jan 25, 2026. It is now read-only.

Migrate to Kotlin 2.1#627

Draft
barbulescu wants to merge 8 commits intoopenrewrite:mainfrom
barbulescu:kotlin_2_1
Draft

Migrate to Kotlin 2.1#627
barbulescu wants to merge 8 commits intoopenrewrite:mainfrom
barbulescu:kotlin_2_1

Conversation

@barbulescu
Copy link
Copy Markdown

What's changed?

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/kotlin/ChangeTypeTest.java
    • lines 18-18

Comment on lines +100 to +103
private fun Any?.isInvalid() = this == null
|| this is FirErrorTypeRef
|| this is FirExpression && this.resolvedType is ConeErrorType
|| this is FirResolvedQualifier && classId == null
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private fun Any?.isInvalid() = this == null
|| this is FirErrorTypeRef
|| this is FirExpression && this.resolvedType is ConeErrorType
|| this is FirResolvedQualifier && classId == null
private fun Any?.isInvalid() = this == null ||
this is FirErrorTypeRef ||
this is FirExpression && this.resolvedType is ConeErrorType ||
this is FirResolvedQualifier && classId == null

@timtebeek
Copy link
Copy Markdown
Member

timtebeek commented Mar 13, 2025

Adding a quick note here that we've since moved this repository into openrewrite/rewrite; let us know if you'd like help porting over the work you have done here!

@timtebeek timtebeek removed this from OpenRewrite Jan 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants