Skip to content

Prevent breakage of usages of Spring's @Nullable #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 3 commits into from
Nov 13, 2024
Merged

Prevent breakage of usages of Spring's @Nullable #602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b652150
Prevent breakage of usages of Spring's @Nullable
kmccarp Nov 13, 2024
4034719
Update jspecify.yml
kmccarp Nov 13, 2024
428af12
Fix test by being more specific about the recipe it runs
timtebeek Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/resources/META-INF/rewrite/jspecify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ recipeList:
- org.openrewrite.java.jspecify.MigrateFromJavaxAnnotationApi
- org.openrewrite.java.jspecify.MigrateFromJakartaAnnotationApi
- org.openrewrite.java.jspecify.MigrateFromJetbrainsAnnotations
- org.openrewrite.java.jspecify.MigrateFromSpringFrameworkAnnotations
# Running the following recipe on current versions of Spring can cause Spring to misunderstand a nullable field.
# For instance, a custom Prometheus scrape endpoint with @Nullable Set<String> includedNames will fail if
# includedNames is null and if @Nullable is @org.jspecify.annotations.Nullable.
# - org.openrewrite.java.jspecify.MigrateFromSpringFrameworkAnnotations

---
type: specs.openrewrite.org/v1beta/recipe
Expand Down
5 changes: 5 additions & 0 deletions src/test/java/org/openrewrite/java/migrate/jspecify/MigrateToJspecifyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

import org.junit.jupiter.api.Test;
import org.openrewrite.DocumentExample;
import org.openrewrite.Issue;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;
Expand Down Expand Up @@ -324,9 +325,13 @@ class Bar {
);
}

@Issue("https://github.com/openrewrite/rewrite-migrate-java/pull/602")
@Test
void migrateFromSpringFrameworkAnnotationsToJspecify() {
rewriteRun(
spec -> spec.recipeFromResource(
"/META-INF/rewrite/jspecify.yml",
"org.openrewrite.java.jspecify.MigrateFromSpringFrameworkAnnotations"),
mavenProject("foo",
//language=java
srcMainJava(
Expand Down