fix: add java version property only to parent pom #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Fix bug where java version property would be add to all submodules of a project instead of only to the root pom
Any additional context
I was having issues with
org.openrewrite.java.migrate.UpgradeToJava21Specifically, it adds the
<java.version>property to each submodule, even if the parent module (in the same repo) already contains this property.I believe this is because of this logic in
UpdateMavenProjectPropertyJavaVersionwhich checks if relativePath has a value.But the problem is that in most cases
relativePathis omitted completely, because if not specified, it defaults to../pom.xml.Now I realise the use case of
<relativePath/>so it was preserved.