Migrate com:intellij:annotations to org.jetbrains:annotations#719
Merged
steve-aom-elliott merged 7 commits intomainfrom May 13, 2025
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
...t/java/org/openrewrite/java/migrate/ComIntelliJAnnotationsToOrgJetbrainsAnnotationsTest.java
Show resolved
Hide resolved
steve-aom-elliott
force-pushed
the
289-com-intellij-annotations-to-org-jetbrains-annotations
branch
from
297bd55 to
f30917e
Compare
...t/java/org/openrewrite/java/migrate/ComIntelliJAnnotationsToOrgJetbrainsAnnotationsTest.java
Show resolved
Hide resolved
timtebeek
reviewed
May 10, 2025
...t/java/org/openrewrite/java/migrate/ComIntelliJAnnotationsToOrgJetbrainsAnnotationsTest.java
Outdated
Show resolved
Hide resolved
...t/java/org/openrewrite/java/migrate/ComIntelliJAnnotationsToOrgJetbrainsAnnotationsTest.java
Outdated
Show resolved
Hide resolved
steve-aom-elliott
force-pushed
the
289-com-intellij-annotations-to-org-jetbrains-annotations
branch
from
5619c4a to
71388b1
Compare
…pendencies to `org.jetbrains:annotations`. As noted in the issue, the packages used within the dependencies were already using `org.jetbrains.annotations` back to the oldest available version of `com.intelli:annotations` so packages do not need to be migrated.
…onsToOrgJetbrainsAnnotationsTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…onsToOrgJetbrainsAnnotationsTest.java
…onsToOrgJetbrainsAnnotationsTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
steve-aom-elliott
force-pushed
the
289-com-intellij-annotations-to-org-jetbrains-annotations
branch
from
71388b1 to
f4542aa
Compare
Jenson3210
approved these changes
May 12, 2025
Contributor
Jenson3210
left a comment
Jenson3210
left a comment
There was a problem hiding this comment.
LGTM!
I pushed the update of the examples yaml and 1 chaining of the methods.
...t/java/org/openrewrite/java/migrate/ComIntelliJAnnotationsToOrgJetbrainsAnnotationsTest.java
Outdated
Show resolved
Hide resolved
…tion from the tests since they're programmatic validation
steve-aom-elliott
force-pushed
the
289-com-intellij-annotations-to-org-jetbrains-annotations
branch
from
f28480b to
3375afd
Compare
steve-aom-elliott
deleted the
289-com-intellij-annotations-to-org-jetbrains-annotations
branch
timtebeek
reviewed
May 13, 2025
Comment on lines
+28
to
+32
| - org.openrewrite.java.dependencies.ChangeDependency: | ||
| oldGroupId: com.intellij | ||
| oldArtifactId: annotations | ||
| newGroupId: org.jetbrains | ||
| newVersion: latest.release |
Member
There was a problem hiding this comment.
Should we add a change package recipe here as well? Or has that not changed?
Contributor
Author
There was a problem hiding this comment.
The package name didn't change between the dependencies, no.
Member
There was a problem hiding this comment.
Ah ok; I was going on these import statements
Contributor
Author
There was a problem hiding this comment.
#289 (comment) They confirmed they didn't change here I believe. For the sake of it, I did also manually verify that was the case by importing the older versions of the library and browsing them in IntelliJ.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
com.intellij:annotationstoorg.jetbrains:annotations#289What's changed?
com.intellij:annotationsdependencies toorg.jetbrains:annotations(the moving of the artifact is already indicated on Maven Central). As noted in the issue, the packages used within the dependencies were already usingorg.jetbrains.annotationsback to the oldest available version ofcom.intelli:annotations(v5.1) so packages do not need to be migrated.Checklist