Skip to content

Fix Java to Jakarta XJC binding migration#741

Merged
MBoegers merged 8 commits intoopenrewrite:mainfrom
evie-lau:xjc
May 27, 2025
Merged

Fix Java to Jakarta XJC binding migration#741
MBoegers merged 8 commits intoopenrewrite:mainfrom
evie-lau:xjc

Conversation

@evie-lau
Copy link
Contributor

@evie-lau evie-lau commented May 22, 2025

What's changed?

  • Fix XJC binding namespace/version in EE9 migration.
  • Fixes failing test and also makes sure both namespace and version upgrade properly all the time.
  • Exclude IBM files from these changes.

What's your motivation?

Fix failing build

Anyone you would like to review specifically?

@timtebeek

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@evie-lau evie-lau self-assigned this May 22, 2025
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite May 22, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/java/migrate/jakarta/UpdateXJCBindingsToJakartaEE.java
    • lines 18-18

@evie-lau
Copy link
Contributor Author

evie-lau commented May 23, 2025

Thinking of some options for tightening the criteria to exclude IBM XML files...

  • update glob to !(ibm-*.xml)
  • negate the following condition
    - org.openrewrite.xml.search.HasNamespaceUri:
        namespaceUri: http://websphere.ibm.com/xml/ns/javaee
    

For the second option, not sure how to do a search excluding that namespace

@MBoegers MBoegers moved this from In Progress to Ready to Review in OpenRewrite May 27, 2025
@MBoegers MBoegers self-requested a review May 27, 2025 07:06
@MBoegers
Copy link
Contributor

@evie-lau thanks for the contribution, as discussed 1:1 I made the last changes and will merge it after CI 🙇

@MBoegers MBoegers merged commit 251b6f0 into openrewrite:main May 27, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite May 27, 2025
@evie-lau evie-lau deleted the xjc branch May 27, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants