Update RemovedJakartaFacesExpressionLanguageClassesTest.java Issue/Bug-5538. Renamed eLResolver to elResolver & other objects#751
Closed
morevinit wants to merge 2 commits intoopenrewrite:mainfrom
Closed
Conversation
Issue/Bug-5538. Renamed eLResolver to elResolver.
Code formatted with default IntelliJ
Author
|
Build failed with validation. It's expecting eLResolver. Did I need to look anywhere else? |
Member
Member
|
This has been reverted upstream; thanks for the report! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue/Bug-5538. Renamed eLResolver to elResolver.
What's changed?
As part of issue 5538, modified eLResolver to elResolver to follow common java object name pattern.
What's your motivation?
I was looking for my good first first commit in public repo. Not sure if I am following everything correctly.
Anything in particular you'd like reviewers to focus on?
I have also modified eLException -> elException and elException1 = elException1
Anyone you would like to review specifically?
@greg-at-moderne as you opened this issue. @timtebeek @Jenson3210 FYI
Checklist